Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notification: create notification templates #350

Merged
merged 1 commit into from
Jul 18, 2019
Merged

notification: create notification templates #350

merged 1 commit into from
Jul 18, 2019
+342 −51

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Jun 19, 2019 •
edited
Loading

  • Adds notification templates by type, language and communication channel.

Co-Authored-by: Peter Weber [email protected]
Co-Authored-by: Aly Badr [email protected]

@BadrAly BadrAly changed the title (WIP): notification templates: create templates by lang by type by channel (WIP) notification templates: create templates by lang by type by channel Jun 19, 2019
@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch from 217f927 to c901f90 Compare July 1, 2019 08:20
@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch 2 times, most recently from 0a2abc2 to 4403b2f Compare July 2, 2019 06:22
@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch from 4403b2f to 8fb0924 Compare July 15, 2019 15:07
@BadrAly BadrAly changed the title (WIP) notification templates: create templates by lang by type by channel notification templates: create notification templates Jul 15, 2019
@BadrAly BadrAly changed the title notification templates: create notification templates notification: create notification templates Jul 15, 2019
@BadrAly BadrAly requested a review from Garfield-fr July 16, 2019 05:59
@BadrAly BadrAly requested a review from pronguen July 16, 2019 08:07
@Garfield-fr
Copy link
Contributor

In all templates, replace tabs with space

@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch 5 times, most recently from ffa48ac to 3bce0b2 Compare July 17, 2019 14:54
@BadrAly
Copy link
Author

BadrAly commented Jul 18, 2019

In all templates, replace tabs with space

Fixed

pronguen
pronguen suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only authors in notifications of organisation 2 are displayed
  • When displayed, author field is separated from title by an unnecessary newline (see example below). When not displayed, there are two newline before the title.
  • Overdue template: "Avec nos compliments" with a typing error
  • Recall template: unnecessary newline between first and second sentences in all languages

Dear patron,

The document you borrowed has been requested by another person.
An extension of the loan period is therefore no longer possible and we kindly ask you to return it at the latest by the due date.

Author : Suisse. Département fédéral de justice et police

Title: Instructions sur la constatation de l'ébriété : (fondées sur l'art. 150, 6e al., OAC)
Due date: 16.08.2019
Note: Non-extendable

You can consult your account at: https://ils.test.rero.ch/patrons/profile

Best regards

Hogwarts Library
Highlands, Scotland, Great Britain

@pronguen pronguen self-requested a review July 18, 2019 07:42
@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch from 3bce0b2 to 09e8d1f Compare July 18, 2019 08:05
@BadrAly
Copy link
Author

BadrAly commented Jul 18, 2019 

* Only authors in notifications of organisation 2 are displayed

* When displayed, author field is separated from title by an unnecessary newline (see example below). When not displayed, there are two newline before the title.

* Overdue template: "Avec nos compliments" with a typing error

* Recall template: unnecessary newline between first and second sentences in all languages

Dear patron,
The document you borrowed has been requested by another person.
An extension of the loan period is therefore no longer possible and we kindly ask you to return it at the latest by the due date.
Author : Suisse. Département fédéral de justice et police
Title: Instructions sur la constatation de l'ébriété : (fondées sur l'art. 150, 6e al., OAC)
Due date: 16.08.2019
Note: Non-extendable
You can consult your account at: https://ils.test.rero.ch/patrons/profile
Best regards
Hogwarts Library
Highlands, Scotland, Great Britain

Fixed

@BadrAly BadrAly requested review from Garfield-fr and removed request for Garfield-fr July 18, 2019 08:17
@rerowep
notification templates: create notification templates
81aaee9 
* Adds notification templates by type, language and communication channel.

Co-Authored-by: Peter Weber <[email protected]>
Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the baa-#884-notification-templates branch from 09e8d1f to 81aaee9 Compare July 18, 2019 08:26
@BadrAly BadrAly merged commit 0bbd6f5 into rero:dev Jul 18, 2019
@BadrAly BadrAly deleted the baa-#884-notification-templates branch August 27, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronguen pronguen pronguen approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BadrAly @Garfield-fr @pronguen @iGormilhit